Re: Proposed patch for 8.3 VACUUM FULL crash

Поиск
Список
Период
Сортировка
От Gregory Stark
Тема Re: Proposed patch for 8.3 VACUUM FULL crash
Дата
Msg-id 87ve4vkwr8.fsf@oxford.xeocode.com
обсуждение исходный текст
Ответ на Proposed patch for 8.3 VACUUM FULL crash  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Proposed patch for 8.3 VACUUM FULL crash  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches
"Tom Lane" <tgl@sss.pgh.pa.us> writes:

> On investigation the problem occurs because we changed vacuum.c's
> PageGetFreeSpaceWithFillFactor() to use PageGetHeapFreeSpace()
> instead of just computing pd_upper - pd_lower as it had done in
> every previous release.  This was *not* a good idea: VACUUM FULL
> does its own accounting for line pointers and does not need "help".

Fwiw this change appears to have crept in when the patch was merged.
Ironically while most of us have been complaining about patches not being
widely visible and tested outside of CVS in this case we perhaps suffered from
the opposite problem. The patch was fairly heavily tested on this end before
it was posted and I'm not sure those tests have been repeated since the merge.

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's 24x7 Postgres support!

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: tzcode update
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Proposed patch for 8.3 VACUUM FULL crash