Re: How to submit a patch

Поиск
Список
Период
Сортировка
От Gregory Stark
Тема Re: How to submit a patch
Дата
Msg-id 87ve2hp9uw.fsf@oxford.xeocode.com
обсуждение исходный текст
Ответ на Re: How to submit a patch  (Heikki Linnakangas <heikki@enterprisedb.com>)
Ответы Re: How to submit a patch  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
"Heikki Linnakangas" <heikki@enterprisedb.com> writes:

> Workflow A:
>
> 1. You post patch to pgsql-patches
> 2. a committer picks it up immediately, and commits it.

I'm more interested in knowing what happens when a committer *doesn't* commit
it. Personally I would almost rather a committer not commit my patch but
instead return feedback on the first go-around than commit it.

I would rather hear about any objections and fix them myself and in the
process learn how to do it better next time. It just isn't as good a learning
experience when I read the commit diffs and have to try to figure out what the
rationale was for the changes.

That's why waiting until feature freeze was so awful from my point of view.
There was never any time left to return patches to the author so Tom ended up
reworking any patches we really wanted.

--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com Ask me about EnterpriseDB's PostGIS support!


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Stephen Denne"
Дата:
Сообщение: Re: count(*) performance improvement ideas
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: How to submit a patch