Re: Review of patch renaming constraints

Поиск
Список
Период
Сортировка
От Dimitri Fontaine
Тема Re: Review of patch renaming constraints
Дата
Msg-id 87vcmeoxzk.fsf@hi-media-techno.com
обсуждение исходный текст
Ответ на Re: Review of patch renaming constraints  (Peter Eisentraut <peter_e@gmx.net>)
Список pgsql-hackers
Hi,

Peter Eisentraut <peter_e@gmx.net> writes:
> On tor, 2012-01-12 at 22:43 -0600, Joshua Berkus wrote:
>> Most normal uses of alter table ... rename constraint ... worked
>> normally.  However, the patch does not deal correctly with constraints
>> which are not inherited, such as primary key constraints:
>
> New patch which works around that issue.

I've been reviewing this new patch and it seems ready for commiter for
me: the code indeed looks like it's always been there, the corner cases
are covered in the added regression tests, including the one Josh ran
into problem with in the previous round of testing.

The regression test covering made me lazy enough not to retry the patch
here, I trust Peter on testing his own work here :)

I'll update my command trigger patch as soon as this one makes it in.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Hans-Jürgen Schönig
Дата:
Сообщение: Re: pg_prewarm
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Scaling XLog insertion (was Re: Moving more work outside WALInsertLock)