Re: Speedup usages of pg_*toa() functions

Поиск
Список
Период
Сортировка
От Andrew Gierth
Тема Re: Speedup usages of pg_*toa() functions
Дата
Msg-id 87v9jz5qsl.fsf@news-spur.riddles.org.uk
обсуждение исходный текст
Ответ на Re: Speedup usages of pg_*toa() functions  (Ranier Vilela <ranier.vf@gmail.com>)
Список pgsql-hackers
>>>>> "Ranier" == Ranier Vilela <ranier.vf@gmail.com> writes:

 Ranier> Sorry, my mistake.

 Ranier> uvalue = (uint64) 0 - value;

This doesn't gain anything over the original, and it has the downside of
hiding an int64 to uint64 conversion that is actually quite sensitive.
For example, it might tempt someone to rewrite it as

    uvalue = -value;

which is actually incorrect (though our -fwrapv will hide the error).

-- 
Andrew (irc:RhodiumToad)



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiko Sawada
Дата:
Сообщение: Re: Resetting spilled txn statistics in pg_stat_replication
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Terminate the idle sessions