Re: Vacuum statistics

Alena Rybakina <lena.ribackina@yandex.ru> writes:

> 1. Naming: The meaning of 'visible/frozen_pages_cleared' seems to me as
> cleared pages rather then cleared marks... Maybe it should be
> 'visible_page_marks_cleared'?
>
> I agree, this improves clarity. I've renamed it as proposed. 
>
>  2. Mention of a <command>VACUUM</command> in the docs may be understood
> as related to manual VACUUM command only. However, autovacuum is
> accounted as well.. I think we can use just term 'vacuum' here as a
> facility rather than command.
>
> Fixed. Clarified that this applies to both manual
> <command>VACUUM</command> and autovacuum.

I think it is good now
>
> I also added an additional test scenario where one process holds a
> transaction open while another process deletes tuples. We expect that
> the all-visible and all-frozen flags, previously set by VACUUM, are
> cleared only after the deleting transaction commits and the changes
> become visible.
>

I'm happy with the patch now.
--
Best regards, Andrei Zubkov
Postgres Professional