Re: Sampling profiler updated

Поиск
Список
Период
Сортировка
От Dimitri Fontaine
Тема Re: Sampling profiler updated
Дата
Msg-id 87skgqm6h8.fsf@hi-media-techno.com
обсуждение исходный текст
Ответ на Re: Sampling profiler updated  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Hi,

Tom Lane <tgl@sss.pgh.pa.us> writes:
> For the record, I think this patch is a waste of manpower and we should
> rely on dtrace/systemtap.  However, if we are going to make our own
> homegrown substitute for those facilities, a minimum requirement should
> be that it uses the dtrace macros already put into the sources, rather
> than expecting that it gets to clutter the code some more with its own
> set of tracing markers.

I think going from this form of the patch to reusing dtrace macros means
providing another entirely different patch to solve the issue (even if
the system view and its support function could remain about the same),
so I've updated the patch commit fest status to rejected.

Regards,
-- 
dim


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Sampling profiler updated
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: [PATCH] "could not reattach to shared memory" on Windows