Re: constants for tar header offsets

Поиск
Список
Период
Сортировка
От Dagfinn Ilmari Mannsåker
Тема Re: constants for tar header offsets
Дата
Msg-id 87o7nluo1g.fsf@wibble.ilmari.org
обсуждение исходный текст
Ответ на constants for tar header offsets  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: constants for tar header offsets
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:

> On Tue, Apr 18, 2023 at 12:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmm, you're right: I checked the POSIX.1-2018 spec as well, and
>> it agrees that the prefix field is 155 bytes long.  Perhaps just
>> add another comment line indicating that 12 bytes remain unassigned?
>
> OK. Here's v2, with that change and a few others.

It still has magic numbers for the sizes of the fields, should those
also be named constants?

- ilmari



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: constants for tar header offsets
Следующее
От: Aleksander Alekseev
Дата:
Сообщение: Re: [PATCH] Compression dictionaries for JSONB