Re: pgsql: Add a note about another issue that needs to be considered before

"Tom Lane" <tgl@postgresql.org> writes:

> Log Message:
> -----------
> Add a note about another issue that needs to be considered before
> changing the TOAST size thresholds.

FWIW I found another issue with this variable when I was experimenting with
small block sizes. If you set the target <= the tuple header the toaster
breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I
think the right solution is just to change it to use plain int32 arithmetic
everywhere.

I don't think this affects the default thresholds because even with the
maximum number of columns (1600) the null bitmap can't be as large as 2kB (the
most it can get to is 200 bytes).

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's PostGIS support!