Re: pgsql: Remove useless default clause in switch

Поиск
Список
Период
Сортировка
От Andrew Gierth
Тема Re: pgsql: Remove useless default clause in switch
Дата
Msg-id 87fu3lbe12.fsf@news-spur.riddles.org.uk
обсуждение исходный текст
Ответ на Re: pgsql: Remove useless default clause in switch  (David Rowley <david.rowley@2ndquadrant.com>)
Список pgsql-committers
>>>>> "David" == David Rowley <david.rowley@2ndquadrant.com> writes:

 David> I always thought that when all options were covered that we
 David> generally kept a default just in case someone added another enum
 David> and forgot to update the code.

That's what compiler warnings (-Wswitch, included in -Wall) are for;
it's actually a _bad_ idea to have a default clause in such cases, since
it stops the compiler from warning you.

-- 
Andrew (irc:RhodiumToad)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: pgsql: Remove useless default clause in switch
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: Remove useless default clause in switch