Re: Coverity Open Source Defect Scan of PostgreSQL

Поиск
Список
Период
Сортировка
От Greg Stark
Тема Re: Coverity Open Source Defect Scan of PostgreSQL
Дата
Msg-id 87ek1doqhn.fsf@stark.xeocode.com
обсуждение исходный текст
Ответ на Re: Coverity Open Source Defect Scan of PostgreSQL  (Alvaro Herrera <alvherre@commandprompt.com>)
Ответы Re: Coverity Open Source Defect Scan of PostgreSQL  (Martijn van Oosterhout <kleptog@svana.org>)
Список pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:

> but they do make the mistake of not noticing that ereport(ERROR)
> does not continue execution. 

There is a way in gcc to indicate that a function never returns. But in
Postgres it's a bit weird since elog()/ereport() sometimes return and
sometimes don't. Perhaps it would be better to make the forms that don't
return separate functions. Then hopefully they can be marked to not trigger
these kinds of warnings.

> We all know that this is not a bug.  There are lots of these, as you can
> imagine.  
> 
> There are lots of other "not a bugs".  For example in initdb, there is a
> lot of noise about how we don't free the resources.

Presumably the reason they don't immediately release the reports is for fear
of security holes revealed. Once somebody has checked the errors and checked
for any exploitable holes would it be possible to just open access to anyone
so mere mortals can clean up the mundane bugs?

-- 
greg



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: problem with large maintenance_work_mem settings and
Следующее
От: Martijn van Oosterhout
Дата:
Сообщение: Re: Coverity Open Source Defect Scan of PostgreSQL