Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jan 1, 2024 at 6:05 PM Dagfinn Ilmari Mannsåker
> <ilmari@ilmari.org> wrote:
>> Thanks. I've fixed the commit message (and elaborated it a bit more why
>> I think it's a valid and safe fix).
>
> Regarding 0001:
>
> - AIUI, check_decls.m4 is copied from an upstream project, so I don't
> think we should tinker with it.
It contains modified versions of a few macros from Autoconf's
general.m4¹, specifically _AC_UNDECLARED_WARNING (since renamed to
_AC_UNDECLARED_BUILTIN upstream) and _AC_CHECK_DECL_BODY. That has
since been updated² to spell François' name correctly, so I think we
should follow suit (and maybe also check if our override is even still
necessary).
[1]: http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=history;f=lib/autoconf/general.m4;hb=HEAD
[2]: http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commitdiff;h=8a228e9d58363ad3ebdb89a05bd77568d1d863b7
> - I'm not convinced by encrypter->encryptor
> - I'm not convinced by multidimension-aware->multidimensional-aware
I don't feel particularly strongy about these.
> - I'm not convinced by cachable->cacheable
If nothing else, consistency. There are 13 occurrences of "cacheable"
and only three of "cachable" in the tree.
> - You corrected restorting to restarting, but I'm wondering if Andres
> intended restoring?
Yeah, re-reading the sentence that's clearly meant to be "restoring".
> Committed the rest of 0001.
>
> 0002-0005 look OK to me, so I committed those as well.
Thanks!
> With regard to 0006, we typically use indexes rather than indices as
> the plural of "index", although exceptions exist.
We (mostly) use indexes when referring to database indexes (as in btree,
gist, etc.), but indices when referring to offsets in arrays, which is
what this variable is about.
- ilmari