On Fri, 2021-07-30 at 16:22 +0900, Michael Paquier wrote:
> Looking at the past, it was the intention of 05f3f9c7 to go through
> the hook even if SET TABLESPACE does not move the relation, so you
> are
> right that ALTER TABLE is inconsistent to not do the same for LOGGED,
> UNLOGGED and ACCESS METHOD if all of them do nothing to trigger a
> relation rewrite.
>
> Now, I am a bit biased about this change and if we actually need it
> for the no-op path. If we were to do that, I think that we need to
> add in AlteredTableInfo a way to track down if any of those
> subcommands have been used to allow the case of rewrite == 0 to
> launch
> the hook even if these are no-ops. And I am not sure if that's worth
> the code complication for an edge case. We definitely should have a
> hook call for the case of rewrite > 0, though.
It sounds like anything we do here should be part of a larger change to
make it consistent. So I'm fine with the patch you posted.
Regards,
Jeff Davis