Re: 0x1A in control file on Windows

ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> I found a bug that pg_controldata ends with error if control files
> contain 0x1A (Ctrl+Z) on Windows.

> We probably need to add PG_BINARY when we open control files
> because 0x1A is an end-of-file marker on Windows.

Well, why is that a bug?  If the platform is so silly as to define text
files that way, who are we to argue?
        regards, tom lane