Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5

Masahiko Sawada <sawada.mshk@gmail.com> writes:
> Pushed the fix (d87d07b7ad3). Thank you for working on this fix.

There is something not right about the v13 version of this patch.
BF member trilobite, which builds with -DCLOBBER_CACHE_ALWAYS,
is showing this failure [1]:

diff -U3
/home/buildfarm/trilobite/buildroot/REL_13_STABLE/pgsql.build/contrib/test_decoding/expected/invalidation_distribution.out
/home/buildfarm/trilobite/buildroot/REL_13_STABLE/pgsql.build/contrib/test_decoding/output_iso/results/invalidation_distribution.out
---
/home/buildfarm/trilobite/buildroot/REL_13_STABLE/pgsql.build/contrib/test_decoding/expected/invalidation_distribution.out
  2025-06-17 10:24:24.382768613 +0200 
+++
/home/buildfarm/trilobite/buildroot/REL_13_STABLE/pgsql.build/contrib/test_decoding/output_iso/results/invalidation_distribution.out
  2025-06-17 15:01:53.921913314 +0200 
@@ -31,7 +31,7 @@
 step s2_get_binary_changes: SELECT count(data) FROM pg_logical_slot_get_binary_changes('isolation_slot', NULL, NULL,
'proto_version','1', 'publication_names', 'pub') WHERE get_byte(data, 0) = 73; 
 count
 -----
-    0
+    1
 (1 row)

I can reproduce that locally if I add -DCLOBBER_CACHE_ALWAYS.
Have not looked for the cause.

            regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=trilobite&dt=2025-06-17%2008%3A24%3A00