On 9/29/16 11:23 PM, Thomas Munro wrote:
> The regression test fails. The expected error messages show the old
> wording, so I think you forgot to add a file. Also, should
> contrib/require_where/Makefile define REGRESS = require_where? That
> would allow 'make check' from inside that directory, which is
> convenient and matches other extensions. Please find attached
> fix-regression-test.patch which also applies on top of
> training_wheels_005.patch and fixes those things for me, and also adds
> a couple of extra test cases.
I don't think we need to have a separate data file to load a few test
rows. A plain INSERT statement will do.
> It would be really nice to be able to set this to 'Ready for
> Committer' in this CF. Do you want to post a v6 patch or are you
> happy for me to ask a committer to look at v5 + these three
> corrections?
As a committer, I would prefer a single patch to be posted.
Before it gets there, I would still like to see the documentation expanded.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services