Wrong comment in tuptable.h

Поиск
Список
Период
Сортировка
От Jeff Davis
Тема Wrong comment in tuptable.h
Дата
Msg-id 84af28311995d6b3f584b254bff7e8664124d7c1.camel@j-davis.com
обсуждение исходный текст
Ответы Re: Wrong comment in tuptable.h  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers

  /*
   * Return a copy of heap tuple representing the contents of the slot.
The
   * copy needs to be palloc'd in the current memory context. The slot
   * itself is expected to remain unaffected. It is *not* expected to
have
   * meaningful "system columns" in the copy. The copy is not be
"owned" by
   * the slot i.e. the caller has to take responsibility to free memory
   * consumed by the slot.
   */
  HeapTuple (*copy_heap_tuple) (TupleTableSlot *slot);

But acquire_sample_rows() calls ExecCopySlotHeapTuple(), and then
subsequently sorts the rows by TID. Is acquire_sample_rows() doing
something it shouldn't, or is the comment mistaken?

Regards,
    Jeff Davis





В списке pgsql-hackers по дате отправления:

Предыдущее
От: Zhihong Yu
Дата:
Сообщение: Re: SQL/JSON: JSON_TABLE
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Wrong comment in tuptable.h