On 23.09.21 12:34, Michael Paquier wrote:
> On Wed, Sep 22, 2021 at 03:18:43PM +0000, Jacob Champion wrote:
>> On Wed, 2021-09-22 at 10:20 +0200, Peter Eisentraut wrote:
>>> This should be added to each level of a function call that represents a
>>> test. This ensures that when a test fails, the line number points to
>>> the top-level location of the test_role() call. Otherwise it would
>>> point to the connect_ok() call inside test_role().
>>
>> Patch LGTM, sorry about that. Thanks!
>
> For the places of the patch, that seems fine then. Thanks!
committed
> Do we need to care about that in other places? We have tests in
> src/bin/ using subroutines that call things from PostgresNode.pm or
> TestLib.pm, like pg_checksums, pg_ctl or pg_verifybackup, just to name
> three.
Yeah, at first glance, there is probably more that could be done. Here,
I was just looking at a place where it was already and was accidentally
removed.