Re: Refactor compile-time assertion checks for C/C++

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Refactor compile-time assertion checks for C/C++
Дата
Msg-id 8447.1584020634@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Refactor compile-time assertion checks for C/C++  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Refactor compile-time assertion checks for C/C++  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> So, should we add a reference about both in the new comment?  I would
> actually not add them, so I have used your suggestion in the attached,
> but the comment block above does that for _Static_assert().  Do you
> think it is better to add some references to some of those compilers
> (say GCC 4.3, MSVC)?  Just stick with your suggestion?  Or stick with
> your version and replace the reference to GCC 4.6 with something like
> "recent compilers"?

I don't feel a need to expend a whole lot of sweat there.  The existing
text is fine, it just bugged me that the code deals with three cases
while the comment block only acknowledged two.  So I'd just go with
what you have in v3.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: SQL/JSON: functions
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Add an optional timeout clause to isolationtester step.