Re: duplicate logging in pg_createsubscriber
| От | Chao Li |
|---|---|
| Тема | Re: duplicate logging in pg_createsubscriber |
| Дата | |
| Msg-id | 83BE4BD6-DDCC-461A-A038-EBFB4A03B537@gmail.com обсуждение исходный текст |
| Ответ на | duplicate logging in pg_createsubscriber (Peter Smith <smithpb2250@gmail.com>) |
| Ответы |
Re: duplicate logging in pg_createsubscriber
|
| Список | pgsql-hackers |
On Oct 8, 2025, at 14:29, Peter Smith <smithpb2250@gmail.com> wrote:Perhaps that 2nd log was once supposed to say "created" (past tense),
but even that seemed redundant.
Here is a small patch to remove the log duplication by keeping only
the log *within* the function.
Thoughts?
======
Kind Regards,
Peter Smith.
Fujitsu Asutralia
<v1-0001-remove-duplicate-logging-for-slot-creation.patch>
The change is straightforward, especially I like the second change of adding “on publisher”, which makes the message clearer.
For dry-run mode, I see in setup_recovery(), it debug-logs a message with “# dry run mode recovery_target_lsn = xxx”, I think it would be good to add similar debug logs in create_logical_replication_slot(), create_publication() and drop_publication().
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
HighGo Software Co., Ltd.
https://www.highgo.com/
В списке pgsql-hackers по дате отправления: