Re: GIN pageinspect support for entry tree and posting tree

Поиск
Список
Период
Сортировка
От Andrey Borodin
Тема Re: GIN pageinspect support for entry tree and posting tree
Дата
Msg-id 83BBD2B9-6DEF-42DE-9385-0B2BDC9533D3@yandex-team.ru
обсуждение исходный текст
Ответ на Re: GIN pageinspect support for entry tree and posting tree  (Kirill Reshke <reshkekirill@gmail.com>)
Ответы Re: GIN pageinspect support for entry tree and posting tree
Список pgsql-hackers

> On 8 Jan 2026, at 01:57, Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> PFA v10

"Prelimitary cleaunup" has two typos. Also it seems that you used something that is not pgindent.
Looks like clang-format with default settings.


+ errdetail("Expected special size %d, got %d.",
+ (int) MAXALIGN(sizeof(GinPageOpaqueData)),
+ PageGetSpecialSize(page)));
I PageGetSpecialSize() returns uint16, maybe let's cast it to (int) too?

Besides this 2nd patch looks good to me.


Best regards, Andrey Borodin.


В списке pgsql-hackers по дате отправления: