Re: [COMMITTERS] pgsql: Clean up Perl code according toperlcritic

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: [COMMITTERS] pgsql: Clean up Perl code according toperlcritic
Дата
Msg-id 837eb7fd-55bb-1dc6-4727-ca472b0aaaf6@2ndQuadrant.com
обсуждение исходный текст
Ответ на Re: [COMMITTERS] pgsql: Clean up Perl code according to perlcritic  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Список pgsql-hackers
Дерево обсуждения 

On 03/28/2017 05:23 AM, Dagfinn Ilmari Mannsåker wrote:
> +        @opts = grep { !/\$\(/ && /^--/ }
> +            map { (my $x = $_) =~ s/\Q$(top_builddir)\E/\"$topdir\"/; $x;}
> +            split(/\s+/, $1);
>      


The use of this lexical $x variable seems entirely pointless and
obfuscatory. If perlcritic doesn't like it without then that's another
black mark against it IMNSHO.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Clean up Perl code according toperlcritic
Следующее
От: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Clean up Perl code according to perlcritic