Alvaro Herrera <alvherre@commandprompt.com> writes:
> Teodor Sigaev wrote:
>> I didn't change a recognition of fillfactor value, although GIN doesn't
>> use it for now.
> I suggest you take StdRdOptions out of the GinOptions struct, and leave
> fillfactor out of ginoptions. I don't think there's much point in
> supporting options that don't actually do anything. If the user tries
> to set fillfactor for a gin index, he will get an error. Which is a
> good thing IMHO.
+1 ... appearing to accept an option that doesn't really do anything is
likely to confuse users. We didn't have much choice in the previous
incarnation of reloptions, but I think now we should throw errors when
we can.
regards, tom lane