Re: Amcheck verification of GiST and GIN

On 3/27/25 16:30, Mark Dilger wrote:
> 
> 
> On Fri, Feb 21, 2025 at 6:29 AM Tomas Vondra <tomas@vondra.me
> <mailto:tomas@vondra.me>> wrote:
> 
>     Hi,
> 
>     I see this patch didn't move since December :-( I still think these
>     improvements would be useful, it certainly was very helpful when I was
>     working on the GIN/GiST parallel builds (the GiST builds stalled, but I
>     hope to push the GIN patches soon).
> 
>     So I'd like to get some of this in too. I'm not sure about the GiST
>     bits, because I know very little about that AM (the parallel builds made
>     me acutely aware of that).
> 
>     But I'd like to get the GIN parts in. We're at v34 already, and the
>     recent changes were mostly cosmetic. Does anyone object to me polishing
>     and pushing those parts?
> 
> 
> Kirill may have addressed my concerns in the latest version.  I have not
> had time for another review.  Tomas, would you still like to review and
> push this patch?  I have no objection.
> 

Thanks for reminding me. I think the patches are in good share, but I'll
take a look once more, and I hope to get it committed.


regards

-- 
Tomas Vondra