Re: LOCK TABLE Permissions

Stephen Frost <sfrost@snowman.net> writes:

>     if (lockmode == AccessShareLock)
>         aclresult = pg_class_aclcheck(reloid, GetUserId(),
>                                       ACL_SELECT);
> +   else if (lockmode == RowExclusiveLock)
> +       aclresult = pg_class_aclcheck(reloid, GetUserId(),
> +                        ACL_INSERT | ACL_UPDATE | ACL_DELETE | ACL_TRUNCATE);
>     else
>         aclresult = pg_class_aclcheck(reloid, GetUserId(),
>                                       ACL_UPDATE | ACL_DELETE | ACL_TRUNCATE);

Perhaps it would be better to refactor with a local variable for the
aclmask and just one instance of the pg_class_aclcheck call.  Also, I'm
pretty sure that the documentation work needed is more extensive
than the actual patch ;-).  Otherwise, I don't see a problem with this.
        regards, tom lane