Re: BUG #1270: stack overflow in thread in fe_getauthname
| От | Tom Lane |
|---|---|
| Тема | Re: BUG #1270: stack overflow in thread in fe_getauthname |
| Дата | |
| Msg-id | 8224.1096328754@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | BUG #1270: stack overflow in thread in fe_getauthname ("PostgreSQL Bugs List" <pgsql-bugs@postgresql.org>) |
| Ответы |
Re: BUG #1270: stack overflow in thread in fe_getauthname
|
| Список | pgsql-bugs |
"PostgreSQL Bugs List" <pgsql-bugs@postgresql.org> writes:
> With the THREAD_SAFETY changes, a buffer is defined on the stack as:
> char pwdbuf[BUFSIZ];
> This buffer overflows the stack when used in a thread. As the application
> creating the thread cannot be modified to increase the stack size, it would
> probably be prudent to reduce this buffer size (I believe that BUFSIZ is
> around 8192 bytes on most modern Unix implementations).
No, it would be prudent to fix the app. While this one particular
buffer might be larger than needed, we are *not* going to buy into the
notion that libpq needs to run successfully in an 8K stack. This
particular problem is only the tip of the iceberg; hewing to any
such limit is going to require far more drastic changes that just don't
seem worthwhile.
regards, tom lane
В списке pgsql-bugs по дате отправления: