> On 15 Nov 2024, at 21:33, Peter Geoghegan <pg@bowt.ie> wrote:
>
> Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO
> routine, to reset the target page's opaque->btpo_cycleid to 0. This
> makes the REDO routine match original execution, which seems like a
> good idea on consistency grounds.
>
> I propose this for the master branch only.
The change seems correct to me: anyway cycle must be less than cycle of any future vacuum after promotion. I cannot say
anythingabout beauty of resetting or not resetting the field.
I'd suggest renaming the field into something like "btpo_split_vaccycleid". I was aware of index vacuum backtracking,
butit took me a while to build context again.
Best regards, Andrey Borodin.