Hey pgAdmin-Hackers / Dave Page,
here are my suggestions and questions regarding the translation of pgAdmin!
Patches
i18n-cannot.diff
Replaced all occurrences of "can not" with "cannot".
i18n-correction.diff
(De)Capitalized strings to fit the common/usual format, corrected spelling, removed unnecessary characters.
i18n-definition.diff
Unified usage of "definition incomplete".
i18n-quotes.diff
Removed unnecessary quotes. Could be wrong.
i18n-translation.diff
GERMAN TRANSLATION! yeah!
i18n-trim.diff
Removed two linebreaks to improve translation experience.
Questions
Can we change the way " + err.errormsg + " is translated? Same for "" + err.errormsg + "", "" + error_msg + "", "" + res.info + "" in several other files. For me it makes no sense to translate variables rather than their value.
(pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\tables\templates\table\js\table.js, ...)
Is there a way to combine separated translatable string like the one below into one? It's difficult to translate the strings separated without knowing what their meaning is later when they stand together.
'{{ _('Are you sure you wish to move objects ') }}'
+ '"' + args.old_tblspc + '"'
+ '{{ _(' to ') }}'
+ '"' + args.tblspc + '"?',
(pgadmin4\web\pgadmin\browser\server_groups\servers\tablespaces\templates\tablespaces\js\tablespaces.js)
Is "catalog_object_column" something that should be translated? Same for "help_str", "index_constraint", "pga_jobs".
(pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\catalog_objects\columns\templates\catalog_object_column\js\catalog_object_column.js)
(pgadmin4\web\pgadmin\preferences\__init__.py)
(pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\tables\constraints\index_constraint\__init__.py)
(pgadmin4\web\pgadmin\browser\server_groups\servers\pgagent\templates\pga_job\js\pga_job.js)
We got three different notations for "Column name cannot be empty": Are they all needed? As I'm new to pgAdmin I don't know exactly where these strings are used. Can we unify the capitalization and exclamation mark usage here?
(pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\foreign_tables\templates\foreign_tables\js\foreign_tables.js)
(pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\tables\column\templates\column\js\column.js)
(pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\tables\indexes\templates\index\js\index.js)
What does "in explain" mean? That's not clear to me.
(pgadmin4\web\pgadmin\tools\sqleditor\templates\sqleditor\js\sqleditor.js)
Is "server#{1}:{2}:\n{0}" the correct format? To me it looks like there is at least a missing space.
(pgadmin4\web\pgadmin\utils\driver\psycopg2\__init__.py)
Can we reformat "'{{ _('Please specify columns for ') }}' + '{{ node_label }}'" for German translation? Same problem as with the multiline string above (#2). The German sentence structure requires "node_label" to be between the words of "Please specify columns for".
(pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\tables\constraints\index_constraint\templates\index_constraint\js\index_constraint.js)
Thanks in advance and good night. *-*