Re: Thread-unsafe coding in ecpg

Поиск
Список
Период
Сортировка
От Michael Meskes
Тема Re: Thread-unsafe coding in ecpg
Дата
Msg-id 7f0bef53cefcf803b479d143ef29817cd7b721c4.camel@postgresql.org
обсуждение исходный текст
Ответ на Re: Thread-unsafe coding in ecpg  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Thread-unsafe coding in ecpg  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
> It looks to me like the reason that the ecpg tests went into an
> infinite
> loop is that compat_informix/test_informix.pgc has not considered the
> possibility of repeated statement failures:
> ...

Correct, this was missing a safeguard. 

> I know zip about ecpg coding practices, but wouldn't it be a better
> idea
> to break out of the loop on seeing an error?

I wonder if it would be better to make the test cases use the proper
whenever command instead. That would give us a slightly better
functionality testing I'd say.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Chapman Flack
Дата:
Сообщение: Re: PostgreSQL vs SQL/XML Standards
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: proposal: new polymorphic types - commontype and commontypearray