On 2016/11/25 13:51, Ashutosh Bapat wrote:
>>
>> I assume you meant "...right after the column name"?
>>
>> I will modify the grammar to allow that way then, so that the following
>> will work:
>>
>> create table p1 partition of p (
>> a primary key
>> ) for values in (1);
>>
>
> That seems to be non-intuitive as well. The way it's written it looks
> like "a primary key" is associated with p rather than p1.
It kind of does, but it's still a "create table p1" statement, so it's not
that ambiguous, IMHO. Although I'm not attached to this syntax, there may
not be other options, such as moving the parenthesized list right before
"partition of", due to resulting grammar conflicts.
> Is there any column constraint that can not be a table constraint?
NOT NULL, DEFAULT, and COLLATE (although only the first of these is really
a constraint, albeit without a pg_constraint entry)
> If no, then we can think of dropping column constraint syntax all
> together and let the user specify column constraints through table
> constraint syntax. OR we may drop constraints all-together from the
> "CREATE TABLE .. PARTITION OF" syntax and let user handle it through
> ALTER TABLE commands. In a later version, we will introduce constraint
> syntax in that DDL.
Hmm, it was like that in the past versions of the patch, but I thought
it'd be better to follow the CREATE TABLE OF style to allow specifying the
table and column constraints during table creation time. If many think
that it is not required (or should have some other syntax), I will modify
the patch accordingly.
Thanks,
Amit