Re: Enable -Wstrict-prototypes and -Wold-style-definition by default

On 27.03.26 11:07, Bertrand Drouvot wrote:
> That looks ok but I wonder if we should also add '-Werror=vla' to it (
> and remove it from common_warning_flags) to be in sync with what configure.ac
> is doing:
> 
> "
>    PGAC_PROG_CC_CFLAGS_OPT([-Werror=vla])
>    # -Wvla is not applicable for C++
> "

Hmm.  This comment is not actually fully correct.  With g++, you can 
write a VLA and it will work, and also -Wvla will warn about it.  So we 
should actually add that option to C++ as well.  (It is true that VLAs 
are not in standard C++, and g++ with -pedantic will also warn about it.)