On 2023/04/12 5:41, Joseph Koshakow wrote:
> Having said all that I actually think this is the best place for
> is_superuser since it doesn't seem to fit in anywhere else.
Yeah, I also could not find more appropriate place for is_superuser than there.
> I was implying that I thought it would have made more sense for
> is_superuser to be implemented as a function, behave as a function,
> and not be visible via SHOW. However, there may have been a good reason
> not to do this and it may already be too late for that.
The is_superuser parameter is currently marked as GUC_REPORT and
its value is automatically reported to a client. If we change
it to a function, we will need to add functionality to automatically
report the return value of the function to a client, which could
be overkill.
> In my opinion, this is ready to be committed.
Thanks! Given that we have already exceeded the feature freeze date,
I'm thinking to commit this change at the next CommitFest.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION