Re: NOT NULL markings for BKI columns

On Apr 9, 2015, at 5:03 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>> Specifically, this code chunk:
>> 
>> +                   if (defined $attopt)
>> +                   {
>> +                       if ($attopt eq 'PG_FORCE_NULL')
>> +                       {
>> +                           $row{'forcenull'} = 1;
>> +                       }
>> +                       elsif ($attopt eq 'BKI_FORCE_NOT_NULL')
>> +                       {
>> +                           $row{'forcenotnull'} = 1;
>> +                       }
>> +                       else
>> +                       {
>> +                           die "unknown column option $attopt on column
>> $attname"
>> +                       }
>> +                   }
> 
>> We should have BKI_FORCE_NULL instead of PG_FORCE_NULL in the comparison.
> 
> Ick. Thanks. Fixed.
> 
> Just out of interest and if you can answer: What are you using it for? I
> guess it's AS?

Yep.

...Robert