On 11/20/21, 1:58 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
> "Bossart, Nathan" <bossartn@amazon.com> writes:
>> I did find some missing control-C handling in
>> pg_receivewal/pg_recvlogical, though. Attached is a patch for those.
>
> Meh ... I'm inclined to fix those programs by just moving their pqsignal
> calls down to after their initial GetConnection calls, as attached.
> This'd be simple enough to back-patch, for one thing.
>
> It could be argued that this doesn't provide a nice experience if
> (a) somebody changes your password mid-run and (b) you actually
> need to make a new connection for some reason and (c) you want
> to give up at that point instead of putting in the new password.
> But I doubt it's worth so much extra complication to address that
> edge case. We've had about zero field complaints about the existing
> behavior in those programs, so the cost/benefit ratio seems poor.
Yeah, I was looking for a way to simplify this, too. Your approach
seems reasonable enough to me.
Nathan