On 18/10/2018 21:31, Andres Freund wrote:
> On 2018-10-18 22:17:55 +0200, Peter Eisentraut wrote:
>> I'd perhaps change the signature
>>
>> #define unconstify(underlying_type, var)
>>
>> because the "var" doesn't actually have to be a variable.
>
> Hm, so expr, or what would you use?
done
>> Attached is my previous patch adapted to your macro.
>>
>> I'm tempted to get rid of the stuff in dfmgr.c and just let the "older
>> platforms" get the warning.
and done
> Yea, that works for me.
>
> Are you planning to apply this?
and done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services