Re: Missing checks when malloc returns NULL...
От
Tom Lane
Тема
Re: Missing checks when malloc returns NULL...
Дата
Msg-id
7978.1466516782@sss.pgh.pa.us
Ответ на
Missing checks when malloc returns NULL... (Michael Paquier)
Список
Дерево обсуждения
Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Heikki Linnakangas <hlinnaka@iki.fi>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Aleksander Alekseev <a.alekseev@postgrespro.ru>
Re: Missing checks when malloc returns NULL... Aleksander Alekseev <a.alekseev@postgrespro.ru>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Aleksander Alekseev <a.alekseev@postgrespro.ru>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Aleksander Alekseev <a.alekseev@postgrespro.ru>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Aleksander Alekseev <a.alekseev@postgrespro.ru>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Re: Missing checks when malloc returns NULL... Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing checks when malloc returns NULL... Michael Paquier <michael.paquier@gmail.com>
Michael Paquier writes:
> - mcxt.c uses that, which is surprising:
> @@ -704,7 +704,8 @@ MemoryContextCreate(NodeTag tag, Size size,
> {
> /* Special case for startup: use good ol' malloc */
> node = (MemoryContext) malloc(needed);
> - Assert(node != NULL);
> + if (node == NULL)
> + elog(PANIC, "out of memory");
> }
> I think that a PANIC is cleaner here instead of a simple crash.
But the elog mechanism assumes that memory contexts are working.
If this ever actually did fire, no good would come of it.
regards, tom lane
В списке pgsql-hackers по дате отправления
От: Craig Ringer
Дата: