Re: refactoring relation extension and BufferAlloc(), faster COPY

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: refactoring relation extension and BufferAlloc(), faster COPY
Дата
Msg-id 784ad72f-d525-305a-5ab4-45519702a401@iki.fi
обсуждение исходный текст
Ответ на Re: refactoring relation extension and BufferAlloc(), faster COPY  (Andres Freund <andres@anarazel.de>)
Ответы Re: refactoring relation extension and BufferAlloc(), faster COPY  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
> v2-0006-bufmgr-Support-multiple-in-progress-IOs-by-using-.patch

This looks straightforward. My only concern is that it changes the order 
that things happen at abort. Currently, AbortBufferIO() is called very 
early in AbortTransaction(), and this patch moves it much later. I don't 
see any immediate problems from that, but it feels scary.


> @@ -2689,7 +2685,6 @@ InitBufferPoolAccess(void)
>  static void
>  AtProcExit_Buffers(int code, Datum arg)
>  {
> -    AbortBufferIO();
>      UnlockBuffers();
>  
>      CheckForBufferLeaks();

Hmm, do we call AbortTransaction() and ResourceOwnerRelease() on 
elog(FATAL)? Do we need to worry about that?

- Heikki




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: refactoring relation extension and BufferAlloc(), faster COPY
Следующее
От: Isaac Morland
Дата:
Сообщение: Unable to create table of view row type