Re: pgsql: Fix for globals.c- c.h must come first

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Fix for globals.c- c.h must come first
Дата
Msg-id 7842.1529436064@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: Fix for globals.c- c.h must come first  (Andres Freund <andres@anarazel.de>)
Список pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> Are there arguments for doing this in postgres.h rather than c.h?

No, c.h is the correct place.  The core problem is that we have to include
pg_config.h before <stdio.h> et al in order to have consistent libc APIs
(on platforms where this matters), and c.h is what does that.

> I think we shouldn't do this for v11, as it seems likely that some
> extensions would be broken. While not hard to fix, that seems
> unnecessary after beta1? Seems unlikely we'll introduce further cases
> before new features are merged.

Yeah, waiting for v12 seems fine.

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Fix for globals.c- c.h must come first
Следующее
От: Bruce Momjian
Дата:
Сообщение: pgsql: README: add URLs for openldap installation