Re: [PATCH] Store Extension Options

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] Store Extension Options
Дата
Msg-id 7820.1388980253@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCH] Store Extension Options  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Ответы Re: [PATCH] Store Extension Options  (Robert Haas <robertmhaas@gmail.com>)
Re: [PATCH] Store Extension Options  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Re: [PATCH] Store Extension Options  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-hackers
Fabrízio de Royes Mello <fabriziomello@gmail.com> writes:
> You are correct. pg_dump export reloptions using "WITH" clause of CREATE
> TABLE statement. I.e.:

> CREATE TABLE foo (
> )
> WITH (autovacuum_enabled=false, bdr.do_replicate=false);

> So if this statement checks for 'bdr' extension is loaded then in partial
> restore it can be fail.

I see absolutely *nothing* wrong with failing that command if bdr is not
installed.  For an analogy, if this table includes a column of type bar
defined by some extension baz, we are certainly going to fail the
CREATE TABLE if baz isn't installed.

Now, if bdr is installed but the validation doesn't happen unless bdr
is "loaded" in some sense, then that is an implementation deficiency
that I think we can insist be rectified before this feature is accepted.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [PATCH] Store Extension Options
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: Compiling extensions on Windows