Re: strange valgrind reports about wrapper_handler on 64-bit arm

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: strange valgrind reports about wrapper_handler on 64-bit arm
Дата
Msg-id 77dxan5ga3rjxjbnm2vtljntbcpab3wov2zlcdukw75a2qojmu@3mbkzfpv54sd
обсуждение исходный текст
Ответ на Re: strange valgrind reports about wrapper_handler on 64-bit arm  (Nathan Bossart <nathandbossart@gmail.com>)
Ответы Re: strange valgrind reports about wrapper_handler on 64-bit arm
Список pgsql-hackers
Hi,

On 2025-03-07 10:36:35 -0600, Nathan Bossart wrote:
> On Fri, Mar 07, 2025 at 11:32:28AM -0500, Andres Freund wrote:
> > Is it possible that the signal number we're getting called for is above
> > PG_NSIG? That'd explain why the source value is something fairly random?
> > 
> > ISTM that we should add an Assert() to wrapper_handler() that ensures that the
> > signal arg is below PG_NSIG.
> 
> We have such an assertion in pqsignal() before we install wrapper_handler
> for anything.  Is there another way it could be getting called with a
> different signo?

Who the hell knows :).

One potential way would be that we got SIGNAL_ARGS wrong for the platform and
are interpreting some random thing as the signal number.  Or something went
wrong in the windows signal emulation code.  Or ...

It seems cheap insurance to add it both places.

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления: