Re: Cost of AtEOXact_Buffers in --enable-cassert

Andres Freund <andres@anarazel.de> writes:
> The most prohibitively expensive part is the AtEOXact_Buffers check of running 
> through all buffers and checking their pin count. And it makes $app's 
> regression tests take thrice their time...

> Would somebody object agains putting those in an extra define so that those can 
> be disabled in pg_config_manual? Or even disable it by default entirely...

Not a chance for the latter; this is an important sanity check that
catches real coding mistakes with some frequency.

I'd be willing to consider a "half assert" mode that turns off some of
the most expensive checks, but AtEOXact_Buffers is hardly the only thing
that ought to be in that list.  The CLOBBER_FREED_MEMORY and memory
context checking stuff is pretty durn expensive too.
        regards, tom lane