Re: Is VACUUM still crash-safe?

"Mikheev, Vadim" <vmikheev@SECTORBASE.COM> writes:
> If we move tuples in already committed state, a page with new
> tuple position goes to disk and backend crashes before page with
> old tuple position updated then we'll have two version of tuple
> after restart (new tuple with HEAP_MOVED_IN is valid and there is
> no HEAP_MOVED_OFF in old tuple version).

That's not good.  Perhaps VACUUM still needs to fsync the file before
its internal commit?

> I don't know how bad is it for TOAST tables though.

I still don't see anything here that affects the handling of TOAST
tables, which was Hiroshi's original complaint.
        regards, tom lane