Re: BUG #1290: Default value and ALTER...TYPE

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: BUG #1290: Default value and ALTER...TYPE
Дата
Msg-id 7718.1098295649@sss.pgh.pa.us
обсуждение исходный текст
Ответ на BUG #1290: Default value and ALTER...TYPE  ("PostgreSQL Bugs List" <pgsql-bugs@postgresql.org>)
Ответы Re: [HACKERS] BUG #1290: Default value and ALTER...TYPE  (Rod Taylor <pg@rbt.ca>)
Re: [HACKERS] BUG #1290: Default value and ALTER...TYPE  (Neil Conway <neilc@samurai.com>)
Список pgsql-bugs
"PostgreSQL Bugs List" <pgsql-bugs@postgresql.org> writes:
> troels=# create table lookat_feature(
> troels(#   feature_id char(4),
> troels(#   status varchar(2) default 'TODO'
> troels(# );
> CREATE TABLE
> troels=# alter table lookat_feature
> troels-#   alter column status type varchar(4);
> ALTER TABLE
> troels=# insert into lookat_feature (feature_id) values('B034');
> ERROR:  value too long for type character varying(2)

Hmm.  What's going on here is that the stored default expression is
actually of the form('TODO'::varchar)::varchar(2)
where you don't see the coercion to varchar(2) in \d becayuse ruleutils.c
doesn't show implicit casts.  After the ALTER COLUMN it's of the form(('TODO'::varchar)::varchar(2))::varchar(4)
which of course will give an error when used.

Possibly we should make ALTER COLUMN strip any implicit coercions that
appear at the top level of the default expression before it adds on the
implicit coercion to the new column datatype.  I am not sure that this
is a good idea, however; it seems like it might alter the semantics in
unexpected ways.  (The default expression could potentially come through
differently than an actually stored value of the column would do.)

The alternative would seem to be decreeing that this is not a bug.

Comments anyone?
        regards, tom lane


В списке pgsql-bugs по дате отправления:

Предыдущее
От: "PostgreSQL Bugs List"
Дата:
Сообщение: BUG #1290: Default value and ALTER...TYPE
Следующее
От: Rod Taylor
Дата:
Сообщение: Re: [HACKERS] BUG #1290: Default value and ALTER...TYPE