Re: Revoke Connect Privilege from Database not working

Nathan Bossart <nathandbossart@gmail.com> writes:
> I went ahead and tried adding docs, tests, and a commit message.

Thanks!  I was about to conclude that "silence means assent" and
do that work, but you beat me to it.  Your changes look fine,
except that where you have

+   ... A role can only attribute a grant
+   to another role if they possess the privileges of that role.

the word "possess" seems a little ambiguous --- it's not clear whether
it means SET or INHERIT privileges.  The grammar nerd in me doesn't
like "they" either.  How about s/they possess/it inherits/ ?
(likewise in revoke.sgml)

> The
> documentation for these commands might need a revamp.  They seem to meander
> a bit, probably due to decades of organic development.  But that's probably
> not this patch's problem.

Agreed, seems like a task for another day.

            regards, tom lane