On 02.08.23 16:39, Tristan Partin wrote:
> I like the idea. Though the way you have it implemented at the moment
> seems like a trap in that any time zlib.h is included someone also has
> to remember to add this define. I would recommend adding the define to
> the build systems instead.
Ok, moved to c.h.
> Since you put in the work to find the version of zlib that added this,
> You might also want to add `required: '>= 1.2.5.2'` to the
> `dependency('zlib')` call in the main meson.build.
Well, it's not a hard requirement, so I think this is not necessary.
> I am wondering if we
> could remove the `z_streamp` check too. The version that it was added
> isn't obvious.
Yeah, that appears to be very obsolete. I have made an additional patch
to remove that.