Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in
Дата
Msg-id 756.1285713433@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-committers
Bruce Momjian <bruce@momjian.us> writes:
> OK, I used your idea for conversion directly to oid from the system
> catalogs, patch attached.  All the pg_controldata returned integers are
> defined as uint32 in pg_upgrade. Should I use atooid() for some of them
> and define some of them as OID?

No, I don't think so --- most of them are not in fact OIDs.  Probably
best to follow what pg_control.h declares them as.

            regards, tom lane

В списке pgsql-committers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in
Следующее
От: Bruce Momjian
Дата:
Сообщение: pgsql: Have pg_upgrade use strtoul(), not strtol().