Re: Moving more work outside WALInsertLock
| От | Tom Lane |
|---|---|
| Тема | Re: Moving more work outside WALInsertLock |
| Дата | |
| Msg-id | 7530.1323967727@sss.pgh.pa.us обсуждение |
| Ответ на | Re: Moving more work outside WALInsertLock (Jeff Janes <jeff.janes@gmail.com>) |
| Ответы |
Re: Moving more work outside WALInsertLock
|
| Список | pgsql-hackers |
Jeff Janes <jeff.janes@gmail.com> writes:
> On Thu, Dec 15, 2011 at 7:34 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This patch may or may not be useful, but this description of it is utter
>> nonsense, because we already do compute that before taking the lock.
>> Please try again to explain what you're doing?
> Currently the CRC of all the data minus the header is computed outside the lock,
> but then the header's computation is added and the CRC is finalized
> inside the lock.
Quite. AFAICS that is not optional, unless you are proposing to remove
the prev_link from the scope of the CRC, which is not exactly a
penalty-free change.
regards, tom lane
В списке pgsql-hackers по дате отправления: