On 2020/03/10 22:43, Amit Langote wrote:
> On Tue, Mar 10, 2020 at 6:09 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>> So, I will make the patch adding support for --no-estimate-size option
>>> in pg_basebackup.
>>
>> Patch attached.
>
> Like the idea and the patch looks mostly good.
Thanks for reviewing the patch!
> + total size. If the estimation is disabled in
> + <application>pg_basebackup</application>
> + (i.e., <literal>--no-estimate-size</literal> option is specified),
> + this is always <literal>0</literal>.
>
> "always" seems unnecessary.
Fixed.
> + This option prevents the server from estimating the total
> + amount of backup data that will be streamed. In other words,
> + <literal>backup_total</literal> column in the
> + <structname>pg_stat_progress_basebackup</structname>
> + view always indicates <literal>0</literal> if this option is enabled.
>
> Here too.
Fixed.
Attached is the updated version of the patch.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters