Re: Index AM API cleanup

On 04.04.25 14:17, Andres Freund wrote:
> skink/valgrind just started to die during the main regression tests:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-04-04%2011%3A01%3A56

Thanks, fix is on the way.

> The set of commits seem to point to the changes made as part of this thread.
> 
> ==4163809== VALGRINDERROR-BEGIN
> ==4163809== Invalid read of size 4
> ==4163809==    at 0x6983FC: get_actual_variable_range (selfuncs.c:6354)
> ==4163809==    by 0x69E45F: ineq_histogram_selectivity (selfuncs.c:1130)
> ==4163809==    by 0x69E8C7: scalarineqsel (selfuncs.c:689)
> ==4163809==    by 0x69EB35: scalarineqsel_wrapper (selfuncs.c:1460)
> ==4163809==    by 0x69EBFD: scalargesel (selfuncs.c:1501)
> ==4163809==    by 0x6FE1AB: FunctionCall4Coll (fmgr.c:1213)
> ==4163809==    by 0x6FE77C: OidFunctionCall4Coll (fmgr.c:1449)
> ==4163809==    by 0x49C070: restriction_selectivity (plancat.c:1985)
> ==4163809==    by 0x43C8BB: clause_selectivity_ext (clausesel.c:848)
> ==4163809==    by 0x43CB3B: clauselist_selectivity_ext (clausesel.c:136)
> ==4163809==    by 0x43CEE3: clauselist_selectivity (clausesel.c:106)
> ==4163809==    by 0x4441D5: set_baserel_size_estimates (costsize.c:5342)
> ==4163809==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
> 
> 
> A bunch of other instances also started to die recently:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2025-04-04%2011%3A38%3A08
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=canebrake&dt=2025-04-04%2011%3A30%3A09
> 
> Greetings,
> 
> Andres Freund