Re: pgsql: Adjust basebackup.c to suppress compiler warnings.

Magnus Hagander <magnus@hagander.net> writes:
> On Tue, Jan 11, 2011 at 19:42, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Some versions of gcc complain about "variable `tablespaces' might be
>> clobbered by `longjmp' or `vfork'" with the original coding. �Fix by
>> moving the PG_TRY block into a separate subroutine.

> I noticed you didn't create a function prototype at the top of the
> file for this function. Was that intentional, or missed? If it was
> intentional, can you give me a quick lesson in when it should be done
> and whe nit shouldn't? :-)

Oh, I just missed that you had ones for all the others.  Feel free to
add it.

            regards, tom lane