Re: Bizarre coding in recovery target GUC management

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: Bizarre coding in recovery target GUC management
Дата
Msg-id 6c30a0e9-eecb-7b5a-9e3f-63108fa067f7@2ndquadrant.com
обсуждение исходный текст
Ответ на Bizarre coding in recovery target GUC management  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 2020-10-12 18:00, Tom Lane wrote:
> Would someone explain to me why assign_recovery_target_lsn and related GUC
> assign hooks throw errors, rather than doing so in the associated check
> hooks?  An assign hook is not supposed to throw an error.  Full stop, no
> exceptions.  We wouldn't bother to separate those hooks otherwise.

That code is checking whether more than one recovery target GUC has been 
set.  I don't think the check hook sees the right state to be able to 
check that.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: "unix_socket_directories" should be GUC_LIST_INPUT?
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: warn_unused_results